test: add NOTEEVENTS demo data and enable multimodal mortality test#967
Open
haoyu-haoyu wants to merge 1 commit intosunlabuiuc:masterfrom
Open
test: add NOTEEVENTS demo data and enable multimodal mortality test#967haoyu-haoyu wants to merge 1 commit intosunlabuiuc:masterfrom
haoyu-haoyu wants to merge 1 commit intosunlabuiuc:masterfrom
Conversation
Add synthetic NOTEEVENTS.csv.gz to mimic3demo test resources and remove the skip decorator from the multimodal mortality prediction test. The noteevents preprocessor already exists in MIMIC3Dataset. Changes to the multimodal test: - Load a dedicated dataset with the noteevents table included - Replace deprecated .samples attribute with len()/indexing - Use int() on mortality label for tensor-safe comparison - Assert at least one sample has non-empty clinical notes Closes sunlabuiuc#512 Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NOTEEVENTS.csv.gztotest-resources/core/mimic3demo/@unittest.skipfrom multimodal mortality prediction testMIMIC3Dataset— only test data was missingWhat was done
The
preprocess_noteevents()function inmimic3.pyhandles nullcharttimevalues correctly. The YAML config for NOTEEVENTS is properly set up. The only gap was missing test data, which caused the multimodal test to be skipped.Synthetic NOTEEVENTS data
Test plan
test_multimodal_mortality_prediction_mimic3_set_taskruns (was previously skipped)Closes #512